Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] PinCode初值为''时onChange不触发 #2502

Closed
1 task done
koderx opened this issue Sep 20, 2024 · 0 comments · Fixed by #2503
Closed
1 task done

[BUG] PinCode初值为''时onChange不触发 #2502

koderx opened this issue Sep 20, 2024 · 0 comments · Fixed by #2503

Comments

@koderx
Copy link

koderx commented Sep 20, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Which Component

PinCode

Semi Version

2.66.1

Current Behavior

image

应该是受控判定有问题
https:/DouyinFE/semi-design/blob/d279f80d872288b0034ca86df6358ffeecbf0e03/packages/semi-foundation/pincode/foundation.ts#L45C8-L45C70

const isControlledComponent = Boolean(this.getProp("value"));

Expected Behavior

const isControlledComponent = this._isInProps("value");

Steps To Reproduce

No response

ReproducibleCode

No response

Environment

- OS:mac
- browser:chrome

Anything else?

No response
@koderx koderx changed the title [BUG] PinCode初值为''时不受控 [BUG] PinCode初值为''时onChange不触发 Sep 20, 2024
@koderx koderx mentioned this issue Sep 20, 2024
Merged
15 tasks
DaiQiangReal added a commit that referenced this issue Sep 23, 2024
@DaiQiangReal
Merge pull request #2503 from koderx/fix-2502
a7a7c67 
fix: #2502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #2502 koderx/semi-design
1 participant
@koderx