Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip quick move #2461

Merged
merged 8 commits into from
Sep 9, 2024
Merged

Fix tooltip quick move #2461

merged 8 commits into from
Sep 9, 2024

Conversation

DaiQiangReal
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix: 修复 tooltip 在动画开启状态快速滑入并滑出,tooltip 正常消失但是 dom 不卸载的问题

🇺🇸 English

  • Fix: Fixed the issue where the tooltip quickly slides in and out when the animation is on, and the tooltip disappears normally but the dom is not unloaded

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Aug 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0410110:

Sandbox Source
pr-story Configuration

@DaiQiangReal
Copy link
Collaborator Author

20240830-164100.mp4

@pointhalo
Copy link
Collaborator

解释一下原因和修改理由吧,不然后续追溯不了

@DaiQiangReal
Copy link
Collaborator Author

DaiQiangReal commented Aug 30, 2024

原因推断是光标移出后,触发了hide,在动画结束结束前又移入,触发了第二次 show, 然后 show 的动画与js事件和第一次 hide 动画结束触发的的 js 事件的状态混在了一起。

修改的方式是通过 Flag 来在动画正在进行时,忽略掉用户show操作

@DaiQiangReal DaiQiangReal changed the base branch from release to main September 6, 2024 03:56
@DaiQiangReal DaiQiangReal merged commit 5e6c8f9 into main Sep 9, 2024
5 of 6 checks passed
@DaiQiangReal DaiQiangReal deleted the fix_tooltip_quick_move branch September 9, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants