fix: Incorrect suffix position calculation when Typography strong attribute is true #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit accc5c0:
|
|
解除了 codesandbox 的查看权限 |
|
@pandoralink 感谢PR，由于 strong 类型时候，font-weight 为 600，我这边修改成如果是 strong 类型，将容器的 font-weight 设置为 600 |
YyumeiZhang
approved these changes
Sep 27, 2024
semi-design
|
||||||||||||||||||||||||||||||
| Project |
semi-design
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 07m 59s |
| Commit |
|
| Committer | pandoralink |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
11
|
Skipped
|
0
|
Passing
|
264
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ribute is true
中文模板 / Chinese Template
What kind of change does this PR introduce? (check at least one)
PR description
ellipsisContainer 无法准确获取宽度。原因是最终渲染形式为
<strong><span /></strong>，而实际计算基于<span></span>。若 ellipsisContainer 能够主动传入 fontWeight 或者在计算时包裹一层<strong>标签，便可实现准确计算。此外，部分字体的 fontWeight 对宽度影响较为显著。复现链接 codesandbox
Changelog
🇨🇳 Chinese
🇺🇸 English
Checklist
Other
Additional information