Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release RAthena 2.5.0 #165

Closed
11 of 12 tasks
DyfanJones opened this issue Jan 17, 2022 · 3 comments · Fixed by #167
Closed
11 of 12 tasks

Release RAthena 2.5.0 #165

DyfanJones opened this issue Jan 17, 2022 · 3 comments · Fixed by #167

Comments

@DyfanJones
Copy link
Owner

DyfanJones commented Jan 17, 2022

Prepare for release:

  • Check current CRAN check results
  • Polish NEWS
  • urlchecker::url_check()
  • devtools::check_rhub(env_vars=c(R_COMPILE_AND_INSTALL_PACKAGES = "always", LIBARROW_BINARY="true"))
  • devtools::check_win_devel()
  • rhub::check_for_cran(env_vars=c(R_COMPILE_AND_INSTALL_PACKAGES = "always", LIBARROW_BINARY="true"))
  • Update cran-comments.md

Submit to CRAN:

  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • usethis::use_github_release()
  • Finish blog post
@DyfanJones
Copy link
Owner Author

@DyfanJones
Copy link
Owner Author

DyfanJones commented Jan 20, 2022

RAthena unit test failing on the cran: https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/RAthena-00check.html

Unit test helper function output_test_data(size, test_file) used to create test data is causing the issue.

Cran maintianers have asked to have test using the R-devel or to set environmental variables.

Please see the CRAN results page for the package. Reproduction needs a
fully up-to-date version of R-devel, or to use

setenv R_CHECK_LENGTH_1_CONDITION abort,verbose
setenv R_CHECK_LENGTH_1_LOGIC2 abort,verbose

@DyfanJones
Copy link
Owner Author

DyfanJones commented Jan 20, 2022

Prepare for release:

  • Check current CRAN check results
  • Polish NEWS
  • urlchecker::url_check()
  • devtools::check_rhub(env_vars=c("R_COMPILE_AND_INSTALL_PACKAGES" = "always", "LIBARROW_BINARY"="true","_R_CHECK_LENGTH_1_CONDITION_"="abort,verbose","_R_CHECK_LENGTH_1_LOGIC2_"="abort,verbose"))
  • devtools::check_win_devel()
  • rhub::check_for_cran(env_vars=c("R_COMPILE_AND_INSTALL_PACKAGES" = "always", "LIBARROW_BINARY"="true","_R_CHECK_LENGTH_1_CONDITION_"="abort,verbose","_R_CHECK_LENGTH_1_LOGIC2_"="abort,verbose"))
  • Update cran-comments.md

Submit to CRAN:

  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • usethis::use_github_release()
  • Finish blog post

DyfanJones added a commit that referenced this issue Jan 20, 2022
@DyfanJones DyfanJones linked a pull request Jan 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant