Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Improve date / time handling in events & statistics #8425

Merged
merged 13 commits into from
Aug 4, 2023
Merged

Improve date / time handling in events & statistics #8425

merged 13 commits into from
Aug 4, 2023

Conversation

dan-mba
Copy link
Member

@dan-mba dan-mba commented Jul 31, 2023 •
edited
Loading

Changes proposed

The value field on a datetime-local input needs to be in the format YYYY-MM-DDThh:mm.
This PR updates the format to match the expected.

Also updates events to display date/time in local format.
The profile statistics chart was also updated to use local date format.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

@github-actions github-actions bot added the ✍ chore: profile This label will be added on PR with request of Data json addition label Jul 31, 2023
@dan-mba dan-mba removed the ✍ chore: profile This label will be added on PR with request of Data json addition label Jul 31, 2023
@github-actions github-actions bot added the ✍ chore: profile This label will be added on PR with request of Data json addition label Jul 31, 2023
@dan-mba dan-mba removed the ✍ chore: profile This label will be added on PR with request of Data json addition label Jul 31, 2023
@dan-mba dan-mba marked this pull request as draft July 31, 2023 14:13
@github-actions github-actions bot added the ✍ chore: profile This label will be added on PR with request of Data json addition label Jul 31, 2023
Pradumnasaraf
Pradumnasaraf reviewed Jul 31, 2023
View reviewed changes
Copy link
Member

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SaraJaoude SaraJaoude removed the ✍ chore: profile This label will be added on PR with request of Data json addition label Aug 1, 2023
@dan-mba dan-mba changed the title Fix event edit datetime initial value Improve date /time handling in events & statistics Aug 1, 2023
eddiejaoude
eddiejaoude suggested changes Aug 1, 2023
View reviewed changes
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dan-mba dan-mba changed the title Improve date /time handling in events & statistics Improve date / time handling in events & statistics Aug 3, 2023
@dan-mba dan-mba marked this pull request as ready for review August 3, 2023 17:22
eddiejaoude
eddiejaoude approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for figuring this out!! 🔥

@eddiejaoude eddiejaoude merged commit c5ddcf3 into main Aug 4, 2023
14 checks passed
@eddiejaoude eddiejaoude deleted the date-input branch August 4, 2023 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Pradumnasaraf Pradumnasaraf Pradumnasaraf left review comments

@eddiejaoude eddiejaoude eddiejaoude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dan-mba @eddiejaoude @Pradumnasaraf @SaraJaoude