Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

nativescript-plugin-firebase and nativescript admob conflict #284

Closed
deifos opened this issue Feb 15, 2017 · 3 comments
Closed

nativescript-plugin-firebase and nativescript admob conflict #284

deifos opened this issue Feb 15, 2017 · 3 comments
Labels
Android enhancement
Milestone
3.10.0

Comments

@deifos
Copy link

deifos commented Feb 15, 2017

After installing nativescript-admob I'm getting

Build Failed with an exception.

...platforms/android/configurations/nativescript-plugin-firebase/include.gradle' line: 45

`> Failed to apply plugin [id 'com.google.gms.google-services']

For input string: "+"`

Everything was working fine before then.

Thanks for any help.
@EddyVerbruggen
Copy link
Owner

I could try and sync those dependencies forever, or just add AdMob support to this plugin directly as it's part of the Firebase suite nowadays.

Work in progress (expect to land this on Friday):

screen shot 2017-02-15 at 23 03 08

@deifos
Copy link
Author

deifos commented Feb 16, 2017

Sounds great!

Thank you for your quick reply!

@deifos deifos closed this as completed Feb 16, 2017
EddyVerbruggen pushed a commit that referenced this issue Feb 17, 2017
#19 Conflict with nativescript-admob
1ff57c9 
#55 Support for AdMob
#85 Google Service conflits on using nativescript-admob with this plugin
#284 nativescript-plugin-firebase and nativescript admob conflict
EddyVerbruggen pushed a commit that referenced this issue Feb 17, 2017
#19 Conflict with nativescript-admob
ae482bf 
#55 Support for AdMob
#85 Google Service conflits on using nativescript-admob with this plugin
#284 nativescript-plugin-firebase and nativescript admob conflict
@EddyVerbruggen EddyVerbruggen added this to the 3.10.0 milestone Feb 17, 2017
@EddyVerbruggen
Copy link
Owner

Available in 3.10.0

EddyVerbruggen added a commit that referenced this issue Apr 18, 2017
@EddyVerbruggen
#19 Conflict with nativescript-admob
63270fe 
#55 Support for AdMob
#85 Google Service conflits on using nativescript-admob with this plugin
#284 nativescript-plugin-firebase and nativescript admob conflict
EddyVerbruggen added a commit that referenced this issue Apr 18, 2017
@EddyVerbruggen
#19 Conflict with nativescript-admob
37c854c 
#55 Support for AdMob
#85 Google Service conflits on using nativescript-admob with this plugin
#284 nativescript-plugin-firebase and nativescript admob conflict
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Android enhancement
Projects
None yet
Milestone
3.10.0
Development

No branches or pull requests
2 participants
@EddyVerbruggen @deifos