This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Allow standalone Analytics import #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 19, 2018 18:53
I wanted to be able to stick all my analytics stuff onto a worker thread, but for iOS was unable to because several of the delegates were being duplicated. This setup is backwards compatible so that `analytics` can either be used off the main `firebase` module, or as a standalone module, with typings being correctly exported for both usages as well The same thing could probably be done for some of the other portions of the plugin as well, like `firestore`, etc.
…ebase into standalone-analytics
EddyVerbruggen
added a commit
that referenced
this pull request
Apr 24, 2018
|
Thanks @DickSmith! This is a good starting point for further decoupling. FYI I had to change the export of analytics a little to satisfy my IDE, but it was an easy fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to stick all my analytics stuff onto a worker thread, but for iOS was unable to because several of the delegates were being duplicated, even though those delegates aren't directly related to analytics.
This setup is backwards compatible so that
analyticscan either be used off the mainfirebasemodule, or as a standalone module, with typings being correctly exported for both usages as well.The same thing could probably be done for some of the other portions of the plugin as well, like
firestore, etc.This branch is an extension of my fork from #549, which I assume you'll merge before this one, so those changes are present here as well.