Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Stream.groupByKey JSDoc category from utils to grouping #3289

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

dilame
Copy link
Contributor

@dilame dilame commented Jul 17, 2024

No description provided.

@dilame dilame requested a review from mikearnaldi as a code owner July 17, 2024 16:46
@gcanti
Copy link
Contributor

gcanti commented Jul 17, 2024

What about grouped and groupedWithin?

@dilame
Copy link
Contributor Author

dilame commented Jul 17, 2024

Do you think it is also grouping? I was based on assumption that grouping is the category that works with GroupBy module, and grouped* family doesn't do it

@gcanti
Copy link
Contributor

gcanti commented Jul 17, 2024

not sure, groupAdjacentBy is also tagged as a grouping function

…m.groupedWithin` JSDoc category from `utils` to `grouping`
Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: eedd4a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
effect Patch
@effect/cli Patch
@effect/cluster-browser Patch
@effect/cluster-node Patch
@effect/cluster-workflow Patch
@effect/cluster Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/schema Patch
@effect/sql-d1 Patch
@effect/sql-drizzle Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/sql Patch
@effect/typeclass Patch
@effect/vitest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dilame
Copy link
Contributor Author

dilame commented Jul 17, 2024

FMPOV it is more of a buffering based on time than grouping, but changed it also

@tim-smart tim-smart merged commit 4bfe4fb into Effect-TS:main Jul 18, 2024
9 checks passed
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants