Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show plugin configs in listconfigs #3206

Closed
niftynei opened this issue Oct 25, 2019 · 2 comments
Closed

Show plugin configs in listconfigs #3206

niftynei opened this issue Oct 25, 2019 · 2 comments

Comments

@niftynei
Copy link
Collaborator

For maximum correctness, listconfigs should show all configs, including plugins.

@m-schmoock
Copy link
Collaborator

m-schmoock commented Nov 21, 2019

@niftynei how do you want to have the plugin configurations be formatted in the JSON output?
Note that there is aready a duplicated key "plugin" per plugin in the listconfigs output:

ln_cli listconfigs
{
   "# version": "v0.7.3-126-g654faa6-modded",
   "lightning-dir": "/home/will/.lightning",
   "wallet": "sqlite3:///home/will/.lightning/lightningd.sqlite3",
   "plugin": "/home/will/projects/lightning.git/lightningd/../plugins/autoclean",
   "plugin": "/home/will/projects/lightning.git/lightningd/../plugins/fundchannel",
   "plugin": "/home/will/projects/lightning.git/lightningd/../plugins/pay",
   "plugin": "/home/will/.lightning/plugins/sendinvoiceless/sendinvoiceless.py",

For plugins, we could change the output to something like this:

{
   "# version": "v0.7.3-126-g654faa6-modded",
   "lightning-dir": "/home/will/.lightning",
   "wallet": "sqlite3:///home/will/.lightning/lightningd.sqlite3",
   "plugins": {
      "/home/will/projects/lightning.git/lightningd/../plugins/autoclean": {},
      "/home/will/projects/lightning.git/lightningd/../plugins/fundchannel": {},
      "/home/will/projects/lightning.git/lightningd/../plugins/pay": {},
      "/home/will/.lightning/plugins/sendinvoiceless/sendinvoiceless.py": {
         "cltv-final": "10",
         "fee-base": "null",
         "fee-per-satoshi": "null"
      },
      "/home/will/.lightning/plugins/rebalance/rebalance.py": {
         "cltv-final": "10"
      },
      "/home/will/.lightning/plugins/summary/summary.py": {
         "summary-currency": "USD",
         "summary-currency-prefix": "USD $"
      },
      "/home/will/.lightning/plugins/drain/drain.py": {
         "cltv-final": "10"
      }
   }

@m-schmoock
Copy link
Collaborator

Can be closed

@cdecker cdecker closed this as completed Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants