Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tor: Fix an edge case where the connect answer is not zero and not error. #3408

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

Saibato
Copy link
Contributor

@Saibato Saibato commented Jan 10, 2020

The tor proxy might want auth 0x2 or answer what ever not defined
in https://tools.ietf.org/html/rfc1928.

Changelog-Fixed: We don't send any further request if the return code of connect is not zero or error.

@Saibato Saibato changed the title Fix an edge case where the connect answer is not zero and not error. The tor proxy might want auth 0x2 or answer what ever not defined in https://tools.ietf.org/html/rfc1928. Changelog-Fixed: We don't send any further request if the return code of connect is not zero or error. Fix an edge case where the connect answer is not zero and not error. Jan 10, 2020
@Saibato Saibato changed the title Fix an edge case where the connect answer is not zero and not error. Tor: Fix an edge case where the connect answer is not zero and not error. Jan 10, 2020
The tor proxy might want auth 0x2 or answer what ever not defined
in https://tools.ietf.org/html/rfc1928.

Changelog-Fixed: TOR: We don't send any further request if the return code of connect is not zero or error.

Signed-off-by: Saibato <[email protected]>
@cdecker
Copy link
Member

cdecker commented Jan 10, 2020

Rebased on top of master and made the changelog entry a bit more specific by adding the TOR: prefix. Changes can be inspected here. 😉

@cdecker
Copy link
Member

cdecker commented Jan 10, 2020

ACK 5648843

@cdecker cdecker merged commit 9824c14 into ElementsProject:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants