Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take hsm_secret password from stdin, even for hsmtool! #4303

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

darosior
Copy link
Collaborator

@darosior darosior commented Jan 2, 2021

Fixes #4186, based on #4284

Went for the procedure here for the API break. Should we instead support both for 3 releases ? It seemed overkill to me as it's a command-line tool and worse case the user has to input their password twice.

@darosior darosior requested a review from cdecker as a code owner January 2, 2021 22:58
@darosior darosior force-pushed the hsmtool_nopass branch 3 times, most recently from 3255bc1 to 54b97be Compare January 3, 2021 12:32
@darosior
Copy link
Collaborator Author

darosior commented Jan 3, 2021

Travis failure is just a one job timeout https://travis-ci.org/github/ElementsProject/lightning/jobs/752638311

This slightly breaks the API, but still accept the input: we just don't
take it into account anymore.

For `dumponchaindescriptors`, we have to still take the old place of the
`network` parameter into account to not entirely break the API.

Changelog-Added: hsmtool: password must now be entered on stdin. Password passed on the command line are discarded.
Signed-off-by: Antoine Poinsot <[email protected]>
@cdecker
Copy link
Member

cdecker commented Jan 4, 2021

ACK dc1132d

@cdecker cdecker merged commit dd1def3 into ElementsProject:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove <hsm password> entry on command line from hsmtool
2 participants