Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AMR functionality for StatCurrentSolver #588

Open
wants to merge 7 commits into
base: devel
Choose a base branch
from

Conversation

tapegoji
Copy link

@tapegoji tapegoji commented Oct 2, 2024

Modified the StatCurrentSolver to have AMR functionality. Copied the functions from StatElecSolver and modifed them to match the current solver.

@tapegoji tapegoji changed the title Added AMR funcionality Added AMR functionality for StatCurrentSolver Oct 2, 2024
tapegoji and others added 3 commits October 2, 2024 11:52
added a new variable to Adaptive.F90 so it can be written to the otuput by resultoutpusolver. this is used as bgmesh for gmsh
@raback
Copy link
Contributor

raback commented Oct 9, 2024

Thanx for the PR! I had a look and would have some questions/comments before merging.

  • It seems that you need not only "Hvalue" but also "HvalueF". How are they different? If you need "HValueF" do you also need "HValue"?
  • I guess the Gmsh output solver is mostly a copy-paste from the module. Was there a lot of changes? Maybe it would make sense to have it as a library feature to avoid redundancy?
  • You also have indicators for HarmonicAVSolver. Are these working in any meaningful way or just work in progress?

Certainly the features are appreciated. Just want to understand how they plug in.

@raback
Copy link
Contributor

raback commented Oct 9, 2024

Just comparing the Adaptive.F90 routine it seems that with these dirty definitions we could use the standard GmshOutputSolver. Just need to restructure a little...

CALL ListAddLogical(Solver % Values,'File Append',.FALSE.)
CALL ListAddString(Solver % Values, 'Output File Name', 'gmsh_bgmesh.msh')
CALL ListAddString(Solver % Values,'Scalar Field 1','HvalueF')

@raback
Copy link
Contributor

raback commented Oct 9, 2024

I did some minor restricting in branch “GmshAdaptive” so we do not need to have the GsmhOutputSolver in two places almost the same way.

So the idea could be to have
Adaptive Mesh Use Gmsh = Logical True
Mesh Command = File “gsmh -3 mesh.geo -bgm gmsh_bgmesh.msh”
Mesh Conversion Comand = File “ElmerGrid 14 2 mesh.msh -autoclean”

This is not tested at all. Just schematics how things could work. So the StatCurrent stuff could be merged but the Adaptive stuff would come from these modifications.

@tapegoji
Copy link
Author

tapegoji commented Oct 9, 2024

Sounds good to me.
The AVsolver changes can be disregarded. I did not mean to push those changes. sorry about that.

tapegoji and others added 2 commits October 10, 2024 16:37
2- adding Gmsh_ReMesh function to write a background mesh for gmsh. It works if you use a gmsh shell command and an ElmerGrid command to convert it. the gmsh command and elmergrid command should be specified by in the sif command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants