Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement asm! #254

Merged
merged 1 commit into from
Nov 18, 2020
Merged

implement asm! #254

merged 1 commit into from
Nov 18, 2020

Conversation

khyperia
Copy link
Contributor

fixes #230

it's pretty fragile right now and likely needs follow-up PRs for complex shenanigans, but, it probably works for all our use cases!

... also, the declare.rs changes are unrelated, but they snuck into this diff and I'm too lazy to split them into another PR (it's refactoring/cleanup made possible due to some changes a while ago that didn't notice it could be simplified)

@khyperia khyperia requested a review from VZout November 18, 2020 12:32
Copy link
Member

@VZout VZout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mergify mergify bot merged commit bedbc4d into main Nov 18, 2020
@mergify mergify bot deleted the asm branch November 18, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support asm!
2 participants