Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added toolchain check to rustc_codegen_spirv #919

Merged
merged 4 commits into from
Sep 23, 2022
Merged

Added toolchain check to rustc_codegen_spirv #919

merged 4 commits into from
Sep 23, 2022

Conversation

oisyn
Copy link
Contributor

@oisyn oisyn commented Sep 21, 2022

Check can be disabled by specifying skip-toolchain-check feature on either rustc_codegen_spirv or spirv_builder

@oisyn oisyn requested a review from eddyb as a code owner September 21, 2022 15:26
eddyb
eddyb previously requested changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool idea! Most of my comments are nitpicks, especially the more aesthetic ones, the main worry around these things is making sure they're not so fragile that the next time we bump the nightly we forget to update something etc.

crates/rustc_codegen_spirv/build.rs Outdated Show resolved Hide resolved
crates/rustc_codegen_spirv/build.rs Outdated Show resolved Hide resolved
crates/rustc_codegen_spirv/build.rs Outdated Show resolved Hide resolved
crates/rustc_codegen_spirv/build.rs Outdated Show resolved Hide resolved
crates/rustc_codegen_spirv/build.rs Outdated Show resolved Hide resolved
crates/rustc_codegen_spirv/build.rs Outdated Show resolved Hide resolved
crates/rustc_codegen_spirv/build.rs Outdated Show resolved Hide resolved
crates/rustc_codegen_spirv/build.rs Outdated Show resolved Hide resolved
crates/rustc_codegen_spirv/build.rs Outdated Show resolved Hide resolved
crates/rustc_codegen_spirv/build.rs Outdated Show resolved Hide resolved
@oisyn oisyn enabled auto-merge (squash) September 22, 2022 21:35
@oisyn oisyn requested a review from eddyb September 22, 2022 21:36
@mergify mergify bot mentioned this pull request Sep 22, 2022
Merged
@oisyn oisyn requested a review from repi September 23, 2022 08:49
@oisyn oisyn removed the request for review from eddyb September 23, 2022 09:32
@oisyn oisyn dismissed eddyb’s stale review September 23, 2022 09:35

All requested changes are resolved.

@oisyn oisyn merged commit f00f267 into main Sep 23, 2022
@oisyn oisyn deleted the toolchain-check branch September 23, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@repi repi repi approved these changes

@eddyb eddyb eddyb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oisyn @eddyb @repi