Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartupFolders.tkape does not collect startup folder #978

Closed
2thewes opened this issue Oct 14, 2024 · 2 comments · Fixed by #979
Closed

StartupFolders.tkape does not collect startup folder #978

2thewes opened this issue Oct 14, 2024 · 2 comments · Fixed by #979
Assignees
Labels
bug Something isn't working

Comments

@2thewes
Copy link
Contributor

2thewes commented Oct 14, 2024

Hi,
since the latest changes to StartupFolders.tkape the folder C:\Users\%user%\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup is no longer collected.
Instead the path C:\Users\%user%\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\ is collected which contains links to some installed programms (all that have no subfolder in the start menu) but not the start up folder.

The same applies to the System-wide startup folder (C:\ProgramData\Microsoft\Windows\Start Menu\Programs\StartUp)

I dont think that is the exprected behavior for the target.

Maybe @MaxZabuty can give some insight on the changes?

@MaxZabuty
Copy link
Contributor

Hi,

Thank you for bringing this to my attention. You’re absolutely correct, my recent changes mistakenly targeted the broader Programs directory rather than focusing specifically on the Startup subdirectory, which is critical for capturing persistence mechanisms.

To clarify, only the contents of the Startup folder (C:\Users%user%\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup) are executed automatically on login and thus gain persistence. The general Programs folder contains shortcuts to installed programs but does not inherently provide persistence. The same applies to the system-wide folder (C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Startup).

This was an oversight and the target paths should be reverted back to their previous state, ensuring that the collection focuses specifically on the Startup subdirectories as expected.

@2thewes
Copy link
Contributor Author

2thewes commented Oct 14, 2024

Thank you for your reply.
I created PR #979 to fix the issue.

@2thewes 2thewes closed this as completed Oct 14, 2024
@AndrewRathbun AndrewRathbun self-assigned this Oct 14, 2024
@AndrewRathbun AndrewRathbun added the bug Something isn't working label Oct 14, 2024
@AndrewRathbun AndrewRathbun linked a pull request Oct 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants