Include session count in Tinybird test for a corner case #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r case when sessions count may be off. * Add hit to ghost/tinybird/datasources/fixtures/analytics_hits.ndjson * Update tests accrodingly
|
This was pulled in separately to this commit. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes the issue described here, and tests cover that edge case:
tinybirdco/web-analytics-starter-kit#90
However, the session count can also be affected by this bug, so I think I'd be a good idea to include that scenario in the fixture, and update the test cases accordingly.
Note how the sessions count in "firefox" also changes.