Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Kryo fields from BeanSerializer and ObjectArraySerializer classes #176

Closed
romix opened this issue Jan 15, 2014 · 1 comment

Comments

@romix
Copy link
Collaborator

romix commented Jan 15, 2014

The two mentioned classes contain "Kryo kryo" fields, that are not used at all.

https:/EsotericSoftware/kryo/blob/master/src/com/esotericsoftware/kryo/serializers/BeanSerializer.java#L35

https:/EsotericSoftware/kryo/blob/master/src/com/esotericsoftware/kryo/serializers/DefaultArraySerializers.java#L294

Any objections if I remove them?

@serverperformance
Copy link
Contributor

+1, in fact in my fork, and pending of pull request, I had already done it when fixing issue #170

:-)

De: romix [mailto:[email protected]]
Enviado el: miércoles, 15 de enero de 2014 10:17
Para: EsotericSoftware/kryo
Asunto: [kryo] Remove unused Kryo fields from BeanSerializer and ObjectArraySerializer classes (#176)

The two mentioned classes contain "Kryo kryo" fields, that are not used at all.

https:/EsotericSoftware/kryo/blob/master/src/com/esotericsoftware/kryo/serializers/BeanSerializer.java#L35

https:/EsotericSoftware/kryo/blob/master/src/com/esotericsoftware/kryo/serializers/DefaultArraySerializers.java#L294

Any objections if I remove them?


Reply to this email directly or view it on GitHub #176 . https:/notifications/beacon/6210680__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNTMxMDIxNiwiZGF0YSI6eyJpZCI6MjM1NTkzMjR9fQ==--926acc9ad98af6eb451bf772bccf74fa3cf2b442.gif

@romix romix mentioned this issue Jan 23, 2014
@romix romix closed this as completed in 77e319f Jan 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants