feat(tile): add design tokens #10476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriklharper
requested review from
alisonailea and
jcfranco
and removed request for
jcfranco and
benelan
alisonailea
reviewed
Oct 3, 2024
alisonailea
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Thanks Erik! Looking good. I have a few suggestions to ensure we keep the component aligned to current design patterns.
@ashetland can you confirm "heading" "description/text" align with the future cross-component heading patterns?
| } | ||
| } | ||
|
|
||
| :host([selection-appearance="border"][layout="vertical"]) { | ||
| .container.selected { | ||
| box-shadow: inset 4px 0 0 0 var(--calcite-color-brand); |
There was a problem hiding this comment.
only the "x" and "y" axis lengths are in changing between these box-shadows. You could probably simplify this down to a single style prop. Something like....
.container {
box-shadow: inset var(--calcite-internal-tile-shadow-x) var(--calcite-internal-tile-shadow-y) 0 0 var(--calcite-internal-tile-shadow-color, none);
}
:host([selection-appearance="border"]) .container.selected {
--calcite-internal-tile-shadow-color: var(--calcite-tile-color-selected, var(--calcite-color-brand));
}
:host([layout="vertical"]) .container {
--calcite-internal-tile-shadow-x: 4px;
--calcite-internal-tile-shadow-y: 0;
}
:host([layout="horizontal"]) .container {
--calcite-internal-tile-shadow-x: 0;
--calcite-internal-tile-shadow-y: -4px;
}| --calcite-icon-color: var(--calcite-color-text-link); | ||
| --calcite-internal-tile-border-color: var(--calcite-color-text-link); | ||
| --calcite-internal-tile-heading-text-color: var(--calcite-color-text-link); | ||
| --calcite-internal-tile-icon-color: var(--calcite-color-text-link); |
There was a problem hiding this comment.
I think we need to add an extra token for this case --calcite-title-href-text-color
:host([href]:focus:not([disabled])),
:host([href]:hover:not([disabled])) {
.container,
.heading {
color: var(--calcite-title-href-text-color, var(--calcite-color-text-link));
}
.container {
border-color: var(--calcite-title-href-text-color, var(--calcite-color-text-link));
}
}…xt-color-hover" token to allow both a default and overridable hover color.
macandcheese
reviewed
Oct 3, 2024
…ender this unnecessary and we don't want to ship a token we'll have to immediately deprecate
…so that one color token controls both the unfocused and focused states
…irectly on a calcite-tile element selector in CSS
… Restoring selection-appearance border selected styles with box-shadow rules.
…internal-tile-border-color and using brand token for hover, focus states on borders
…calcite-tile-heading-text-color-hover
…way of setting the color of the presentation calcite-icon using a direct color property, and adding additional --calcite-tile-href-icon-color-hover token that defaults to the link color
…le-description-text-color, syncing up all current css properties in tests and demos, commenting out some tests that need fixed in a follow-up
…ption-text-color-hover token with correct fallback, refactoring icon selectors to use css classes instead of element selectors, fixing heading text hover color, updating tests and demos, adding a link token test for heading text and icon hover
…cite-tile-selection-color/hover just like Card does.
…able for selected, hover and focus states instead of the base one. This allows for the base color of the selection icon to be controlled separately from selected/hover/focus state. Not sure if this is the right thing to do, need to follow up
…lharper/7180-tile-tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Adds design tokens for the Tile component.