-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(list)!: Support moving between different lists via keyboard #10480
Draft
driskull
wants to merge
50
commits into
dev
Choose a base branch
from
dris0000/sort-dropdown
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,533
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driskull
changed the title
feat(list): Support keyboard dragging between different Lists
feat(list)!: Support keyboard dragging between different Lists
Oct 3, 2024
driskull
added
the
breaking change
Issues and pull requests with code changes that are not backwards compatible.
label
Oct 3, 2024
driskull
added
the
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
label
Oct 8, 2024
driskull
removed
the
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
label
Oct 8, 2024
# Conflicts: # packages/calcite-components/src/components/list/list.tsx
# Conflicts: # packages/calcite-components/src/components.d.ts
driskull
changed the title
feat(list)!: Support keyboard dragging between different Lists
feat(list)!: Support moving between different lists via keyboard
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Issues and pull requests with code changes that are not backwards compatible.
enhancement
Issues tied to a new feature or request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7537
BREAKING CHANGE: Modifies the component's keyboard sorting experience by using a dropdown menu to move list items.
Summary
action
to allow cursor to be overridenlabel
property for the "Move to" sorting menu to have a name for the list.calcite-sort-handle
component to handle sorting and moving between lists for non mouse usersdragSelected
property: no longer needed.calciteListItemDragHandleChange
event. no longer needed.aria-posinset
andaria-setsize
. These are only needed when only part of the items are availalbe in the DOM. So we can safely remove these.calcite-handle
withcalcite-sort-handle
in thelist
component.