fix(linux): can't get local ip address with libc::ENETUNREACH error #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout default route
src/linux.rs
Outdated
| @@ -158,6 +158,16 @@ fn local_ip_impl(family: RtAddrFamily) -> Result<IpAddr, Error> { | |||
| let mut netlink_socket = NlSocketHandle::connect(NlFamily::Route, None, &[]) | |||
| .map_err(|err| Error::StrategyError(err.to_string()))?; | |||
|
|
|||
| match local_ip_impl_route(family, &mut netlink_socket) { | |||
| Ok(ip_addr) => Ok(ip_addr), | |||
| Err(_error) => local_ip_impl_addr(family, &mut netlink_socket), | |||
There was a problem hiding this comment.
Can we check here for the error to be "LocalIpAddressNotFound"? That way we have a controlled flow for the fallback, allowing us to reduce ambiguity.
Suggested change
| Err(_error) => local_ip_impl_addr(family, &mut netlink_socket), | |
| Err(error) if error == Error::LocalIpAddressNotFound => local_ip_impl_addr(family, &mut netlink_socket), | |
| Err(e) => Err(e) |
There was a problem hiding this comment.
Yes, that's better!
EstebanBorai
approved these changes
Feb 24, 2024
|
@jsydliuqing can you please run |
EstebanBorai
approved these changes
Feb 25, 2024
|
Hi @EstebanBorai ! |
Hey @jsydliuqing! I can do it in a couple hours! |
|
Hi @jsydliuqing! Here is the version containing your PR changes: https://crates.io/crates/local-ip-address/0.6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix(linux): can not get local ip address when the network namespace without default route
#135