Component for motors moving halfs of JF4M detector #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
==========================================
- Coverage 71.09% 70.70% -0.39%
==========================================
Files 23 23
Lines 2726 2748 +22
==========================================
+ Hits 1938 1943 +5
- Misses 788 805 +17 ☔ View full report in Codecov by Sentry. |
takluyver
reviewed
Aug 23, 2024
| if src in dc.control_sources and position_key in dc[src].keys(): | ||
| if ( | ||
| src in dc.control_sources and | ||
| position_key in dc[src].keys(inc_timestamps=False) |
There was a problem hiding this comment.
Suggested change
| position_key in dc[src].keys(inc_timestamps=False) | |
| position_key in dc[src] |
This should work, and can be faster than loading the list of keys.
|
I assume you've tested this manually? It would be good to add some automated tests for it, like you did for the AGIPD 1M quadrant motors. Other than that, I think this all looks fine. |
| raise ValueError("Motors are not found") | ||
| elif len(all_motors) > 1: | ||
| raise ValueError( | ||
| "Many detector found: {', '.join(det_motors.keys())}. " |
There was a problem hiding this comment.
Suggested change
| "Many detector found: {', '.join(det_motors.keys())}. " | |
| "Many detector found: {', '.join(det_motors.keys())}.\n" |
Nitpicking, it might be nicer formatting to print the 'please specify' message on a new line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%subj%
@JamesWrigley @takluyver