Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Development MR #1

Merged
merged 58 commits into from
Nov 21, 2022
Merged

Initial Development MR #1

merged 58 commits into from
Nov 21, 2022

Conversation

RobertRosca
Copy link
Member

@RobertRosca RobertRosca commented Feb 14, 2022

The readme has a quick start section describing usage. The fastest and easiest way to play around with this is in a docker container, specifically the one used for testing as this has python, pip, and a few other packages pre-compiled and installed inside it, saving a lot of time during the tests.

To get started within the container:

# Build the image
docker build .github --tag pyvarium-test-image

# Enter and setup
docker run -it --rm -v (pwd):/src/pyvarium:ro pyvarium-test-image
cd /src/pyvarium
pip install .

# Test
pyvarium --help

Then you can just cd /tmp, pyvarium new env, and follow the instructions in the readme to see if everything works as expected. To make testing easier numpy is already present, so once you've set up a pyvarium environment pyvarium add spack py-numpy should finish pretty quickly, then run pyvarium add pipenv extra-data (or anything else) to add in packages from pip.

Add dependencies

Update dependencies

Add pyaml as dependency

Add loguru and rich

Update .gitignore

Add default configurations

Add template files

Commit semi-finished `new` command(s)

Commit semi-finished `install` command(s)

Remove dependency on poetry

Classes for 'providers'

WIP implementation of install

Restructure files

Rename methods, use with env .venv by default

Add install poetry step

Flesh out class

Multiple changes

- implement logging
- code cleanup
- skip steps if not needed
- improve spack python package parsing
- add docstrings
- fix spack multiprocessing issues

Add global verbosity levels

Update to new loggers

squash with global loggers

Formatting changes

Move installer class, rename pkg to pyvarium

Rename to pyvarium

Rename package directory
Rename variables

Delete templated tests until I come up with good ones

Tidy up code

Update dependencies

Fix error

Restructure installers

Add tests

Add docstrings, clarify var/func names

Add fastroce dep

Cast paths to Path

Use delegates for kwargs, use same var names

Update deps for tests, add more coverage

Add test image build workflow

Add test image build workflow

Implement test workflow using test image

Update deps

Add runs on

Set up CI tests

Explicitly use bash shell for run

Split up step

Prepare for integration tests

Update test image

Spit unit and integration tests

Add compiler find call

Fix typos

Explicitly install gcc

Print off compilers list

Don't clear env vars by default

Try unified codecov upload

Adjust artifact paths

Try codecov files with quotes

Add poetry test

Update lockfile

Set environ to none, set executable to bash

Add version flag, adjust temp paths

md instead of rst readme

Update deps, add pytest opts

Restructure deps

Tidy up

Update to work with new installers

Split unit and integration tests

Add nox file

Use tomlkit and poetry pyproject classes

Add pyvarium tests

Add test image build workflow

Update lockfile

Rename integration test venv for act compat

Make cmd_mp work like cmd

Add module generation printer

Tidy up, finish modulegen
@lgtm-com

This comment was marked as outdated.

@lgtm-com

This comment was marked as outdated.

@lgtm-com

This comment was marked as outdated.

@lgtm-com

This comment was marked as outdated.

@lgtm-com

This comment was marked as outdated.

@lgtm-com

This comment was marked as outdated.

@lgtm-com

This comment was marked as outdated.

@lgtm-com

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@317fe93). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   93.02%           
=======================================
  Files           ?       13           
  Lines           ?      416           
  Branches        ?        0           
=======================================
  Hits            ?      387           
  Misses          ?       29           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2022

This pull request introduces 4 alerts when merging 30b66b9 into 317fe93 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 2 for `__init__` method calls overridden method

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2022

This pull request introduces 4 alerts when merging 9f7a64e into 317fe93 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 2 for `__init__` method calls overridden method

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2022

This pull request introduces 4 alerts when merging f95a178 into 317fe93 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 2 for `__init__` method calls overridden method

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2022

This pull request introduces 4 alerts when merging 309a912 into 317fe93 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 2 for `__init__` method calls overridden method

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 21, 2022

This pull request introduces 4 alerts when merging 4ca8c91 into 317fe93 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 2 for `__init__` method calls overridden method

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 21, 2022

This pull request introduces 4 alerts when merging e870889 into 317fe93 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 2 for `__init__` method calls overridden method

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 21, 2022

This pull request introduces 4 alerts when merging 01c079a into 317fe93 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 2 for `__init__` method calls overridden method

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 21, 2022

This pull request introduces 4 alerts when merging 5a47570 into 317fe93 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 2 for `__init__` method calls overridden method

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@RobertRosca RobertRosca merged commit e3a9906 into main Nov 21, 2022
@RobertRosca RobertRosca deleted the feat/initial-dev branch November 21, 2022 15:57
@lgtm-com
Copy link

lgtm-com bot commented Nov 21, 2022

This pull request introduces 4 alerts when merging fe07ba4 into 317fe93 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 2 for `__init__` method calls overridden method

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant