Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to multiphase hybrid coupling - nodal projection #1254

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Sep 19, 2024

Summary

Previously, spurious currents in multiphase hybrid cases were reduced by not coupling the nodal projection directly to the incoming pressure values. We have found issues with that, and the proposed change is coupling single-phase regions directly and loosely coupling around the interface. Still needs some more testing.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Changes to regression tests of exawind-driver will go along with this, but they run fine with a few tweaks.

@mbkuhn mbkuhn force-pushed the new_multiphase_hybrid_nodalcoupling branch 2 times, most recently from c477cc3 to 3561144 Compare October 8, 2024 15:18
@mbkuhn mbkuhn force-pushed the new_multiphase_hybrid_nodalcoupling branch 2 times, most recently from cc3dfa9 to 9a6df6c Compare October 11, 2024 16:39
@mbkuhn mbkuhn force-pushed the new_multiphase_hybrid_nodalcoupling branch from 9a6df6c to 2548579 Compare October 22, 2024 15:39
@mbkuhn mbkuhn force-pushed the new_multiphase_hybrid_nodalcoupling branch from 2548579 to de26310 Compare October 22, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant