This repository has been archived by the owner on May 23, 2024. It is now read-only.
Generate test data with qualifiers #640
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full link to issue: #633
We should now have everything we need to make this work. Unfortunately, of course, it doesn't. So now we need to figure out why.
4 tasks
gaurav
added a commit
to ExposuresProvider/cam-pipeline
that referenced
this pull request
Aug 1, 2023
gaurav
added a commit
to ExposuresProvider/cam-pipeline
that referenced
this pull request
Nov 5, 2023
These examples are reformatted from ee2eecc06eaad784fb29b9ff3aae9a8f87cf1ced in ExposuresProvider/cam-kp-api#640, which should be the most recent version of that test code. These tests fail, but I wanted to record exactly what they said. I'll update them in later commits.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #620 covers adapting the generation of test data from the existing (and out of date) predicates/MKG data. This PR attempts to replace that with a new process that gets the Biolink class hierarchy and relations directly from the database, allows us to regenerate (and hopefully fix MKG issues like #585) in one fell swoop.
WIP