-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 9.1 - Bug in VisionPortalImpl.close() #942
Comments
Ooops. Yes, that is correct. Unfortunately, the deploy model of the SDK does not facilitate the acceptance of PRs against this repo. A workaround for now would be to (a) stop streaming but not actually close the portal if you're doing it to save resources, or (b) simply allow the built-in clean up to run its course. |
NB: this was missed in testing because the usage of |
This was fixed in v9.2 |
When VisionPortalImpl tries to remove cameraMonitorViewId from viewsInUse, it uses
ArrayList.remove(int)
instead ofArrayList.remove(Object)
. This causes an IndexOutOfBoundsError. Line 663 of VisionPortalImpl should change from:viewsInUse.remove(cameraMonitorViewId);
to
viewsInUse.remove(Integer.valueOf(cameraMonitorViewId));
If other people think this is correct I will submit a PR.
The text was updated successfully, but these errors were encountered: