Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for VirtIO / XEN paravirtual devices in getHardDisk (vda xvda) #152

Closed
wants to merge 1 commit into from

Conversation

alv000h
Copy link

@alv000h alv000h commented Jan 15, 2017

Fixes errors during Capturing / deploying images: "Cannot find disk on system (getHardDisk)"

This error is caused by VirtIO vda devices.

additional information:
https://forums.fogproject.org/topic/9299/issue-virtio-disks-not-found-during-image-capture-deploy

…/ xvda)

  Fixes error: "Cannot find disk on system (getHardDisk)"
mastacontrola added a commit that referenced this pull request Jan 15, 2017
Add in the partition finders for XEN devices and VirtIO support as
suggested in the pull request. While I'm not merging the info create
goes to @alv000h for finding this and creating a pull request.
Only portion missed was the partition table.
@mastacontrola
Copy link
Member

I've added what you've suggested, but did so manually for now. The reasoning behind the choice is two fold. First you're pushing into the master branch which really should be pushing into the dev-branch or working-1.3.2 branch. While this would make the disk visible, it could've had issues finding the partitions on the disk. What I've pushed up should make this change to the partition table as well.

@mastacontrola
Copy link
Member

@alv000h
Copy link
Author

alv000h commented Jan 15, 2017

@mastacontrola thank you so much for your efficient attention!!

Sorry for pushing in master branch, additional information for PR in Readme.md will be nice.

@mastacontrola
Copy link
Member

You didn't do anything wrong. The system isn't perfect, and I don't mind that you pushed into "master".

I'm still getting familiar with Git myself. I'll see if I can get information on which branch to make pull requests too. At the least I'll add a message that just asks that you make pull requests to the dev-branch branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants