Upgrading Scala and fix ScalaLanguageAdapter's code to be Scala's style. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juuxel
reviewed
Mar 20, 2024
modmuss50
reviewed
Mar 26, 2024
This comment was marked as resolved.
This comment was marked as resolved.
|
accept this pr @modmuss50 🙏 |
|
Thanks for this, sorry I missed it. Its not a project I think to check. I think I need to carve out some time to work on this, to set it up in a similar way to how we do it with Kotlin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based #23 ,because the author didn't respond long after I finished fixing it.
In addition to fixing the nested-jar issue in #23, the most widely used version of Scala(3.3.3) is bundled.
TODO
fabric-loomseems doesn't work withscalagradle plugin.link