Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checking for annotation changes before any DD API calls #74

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

lucasreed
Copy link
Contributor

This should fix #72

@lucasreed
Copy link
Contributor Author

Now if an annotation changes, we still see duplicate OnUpdate calls with a new revision number, but at least now if any other part of the deployment/namespace is changed, it shouldn't trigger a GET from the Datadog API to get the current monitor at all.

@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #74 into master will decrease coverage by 1.9%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   57.82%   55.92%   -1.91%     
==========================================
  Files           7        7              
  Lines         441      456      +15     
==========================================
  Hits          255      255              
- Misses        161      176      +15     
  Partials       25       25
Impacted Files Coverage Δ
pkg/config/config.go 75.19% <ø> (ø) ⬆️
pkg/controller/controller.go 39.84% <0%> (-3.24%) ⬇️
pkg/handler/handler.go 52.04% <0%> (-2.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e1b5f...431930f. Read the comment docs.

Copy link
Contributor

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Collaborator

@mjhuber mjhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
noice

@lucasreed lucasreed merged commit 0d69120 into master Jan 10, 2020
@lucasreed lucasreed deleted the lucasreed/fix_duplicate_requests_to_dd branch January 10, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate reconciliation when object is updated or added
3 participants