Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bsuite #38

Merged
merged 14 commits into from
Mar 7, 2023
Merged

add bsuite #38

merged 14 commits into from
Mar 7, 2023

Conversation

jjshoots
Copy link
Member

No description provided.

pseudo-rnd-thoughts
pseudo-rnd-thoughts requested changes Feb 27, 2023
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add registration of the environments?

shimmy/__init__.py Show resolved Hide resolved
shimmy/__init__.py Show resolved Hide resolved
shimmy/__init__.py Show resolved Hide resolved
shimmy/bsuite_compatibility.py Outdated Show resolved Hide resolved
tests/test_bsuite.py Outdated Show resolved Hide resolved
@jjshoots
Copy link
Member Author

jjshoots commented Mar 6, 2023

Tests are waiting for this to be merged on bsuite itself.

@jjshoots
Copy link
Member Author

jjshoots commented Mar 7, 2023

Ready for review and merge.

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 1f96c02 into Farama-Foundation:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjshoots @pseudo-rnd-thoughts