Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NonBlockingJsonParser implements ByteBufferFeeder #483

Closed
wants to merge 1 commit into from

Conversation

kptfh
Copy link

@kptfh kptfh commented Oct 2, 2018

Should fix #478

@kptfh
Copy link
Author

kptfh commented Oct 2, 2018

@cowtowncoder Shouldn't it hit performance?

@cowtowncoder
Copy link
Member

Before considering adding one specific layer of wrapping, I would want actual performance measurements to show it does not hurt performance. Based on past experience I would expect going via ByteBuffer to add measurable amount of overhead (work was with aalto-xml).

@pjfanning
Copy link
Member

This is probably unnecessary now due to #795 - that latter PR adds dedicated byte buffer support as opposed to changing the byte array support to support buffers and arrays.

@cowtowncoder
Copy link
Member

Agreed @pjfanning, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide implementation of async JSON parser fed by ByteBufferFeeder
3 participants