Put back enum field without renaming #4313
Conversation
src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java
Show resolved
Hide resolved
| if (!prop.hasSetter() | ||
| && Objects.nonNull(prop.getField()) | ||
| && (Objects.equals(_type, prop.getField().getType()) && prop.getPrimaryType().isEnumType()) | ||
| ) { |
There was a problem hiding this comment.
I wonder if there is cleaner solution for this... 🤔
Or just extract method to some where (probably not POJOPropertyBuilder, it doens't need to know about Enum stuff)
There was a problem hiding this comment.
Sorry, I should have noticed -- original "fix" is actually totally wrong.
It applies to properties with Enum value but what we want are properties WITHIN type that has properties.
I am not sure how it would have resolved the problem but I can look into fixing the problem. Odd databind had no test for naming strategy with Enum-valued POJO property.
There was a problem hiding this comment.
First thing I think (beyond revert) is to add a test for naming strategy. I can do that.
| // test deserialization | ||
| AsField4302Bean result = SNAKE_MAPPER.readValue( | ||
| a2q("{'some_enum':'SOME_PERSON', 'other_prop':'thisField'}"), AsField4302Bean.class); | ||
| assertEquals(AsField4302Enum.SOME_PERSON, result.someEnum); | ||
| assertEquals("thisField", result.otherProp); |
There was a problem hiding this comment.
This test corresponds to the failing test in ion module --when there is Enum field, we should keep renaming it, same as before
|
Solved via #4314, will close this PR. |
Summary
This PR completes #4311 fix.
This PR fixes behavior introduced by #4311, when Enum is used as field of other class and
POJOPropertiesCollectortries to rename it via_renameUsing(), we just drop the field.Notes