Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for multiline literalBlockStyle with trailing space #366 #501

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Add unit test for multiline literalBlockStyle with trailing space #366 #501

merged 2 commits into from
Oct 4, 2024

Conversation

njank
Copy link
Contributor

@njank njank commented Oct 3, 2024 •
edited by cowtowncoder
Loading

Test to reproduce #366

@cowtowncoder cowtowncoder mentioned this pull request Oct 4, 2024
Open
@cowtowncoder cowtowncoder changed the title add unittest for multiline literalBlockStyle with trailing space #366 Add unit test for multiline literalBlockStyle with trailing space #366 Oct 4, 2024
@cowtowncoder
Copy link
Member

@njank First of all, thank you for contributing this test!

One request: since this is not a test for #215 but #366, could you add it in a new, separate test class?

@njank
Copy link
Contributor Author

njank commented Oct 4, 2024

@cowtowncoder done.
I also added a working test case without trailing space for comparison.

@cowtowncoder cowtowncoder merged commit 1da2d90 into FasterXML:2.19 Oct 4, 2024
4 checks passed
@cowtowncoder
Copy link
Member

Thank you @njank !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njank @cowtowncoder