-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java.lang.NoClassDefFoundError: kotlin/jvm/JvmInline #523
Comments
Hmm, do you have the Kotlin stdlib for the JDK (e.g. |
I've encountered the same thing on upgrading from Spring Boot 2.4.x to 2.6.1. Upgrading from kotlin version 1.4.0 to 1.6.0 fixed this for me weirdly. I've not had time to figure out why. |
My guess is that it is due to a combination of
|
@stepbeekio @ChenZheOnePiece Can either of you confirm @k163377 's hypothesis? |
What are the Kotlin compatibility guarantees offered by this library? I'm not finding anything in the README about this. From what I can tell, the latest version of the library isn't compatible with Kotlin 1.3. |
I did just attempt to compile this library with Kotlin 1.3 compatibility. I was willing to modify the |
@JLLeitschuh We don't have guarantees listed anywhere, though you're right that we should. 2.12 was built against Kotlin 1.4.x and 2.13 uses 1.5.x. |
It would be great if there was a contribution for running something that would cross-check version compatibilities (specific kotlin core, specific Jackson minor version), as a matrix. While automation like Github Actions would be nice -- and actually might make matrix testing easier, come to think of it now -- even one-off script could work. I have sometimes done investigation for example for Guava module/Guava compatibility: https://cowtowncoder.medium.com/jackson-guava-compatibility-b0b61ac59b28 but it's maybe bit too manual approach, using https:/cowtowncoder/jackson-compat-minor which is sort of designed for tests, but mostly for Jackson core / Jackson module dimension. Alternatively we could just rely on community, asking for reports on combinations that are known to work (or to NOT work). |
I was thinking about doing all of this, but it would involve splitting the base project into two separate projects. Totally doable, but more difficult to do with Maven IMHO. Using Gradle could significantly simplify this. |
Which base project would you be thinking of here? I would not suggest doing this for Kotlin module itself (f.ex). At any rate, the idea of external integration test project seems useful but I have not had much time to spend on figuring out good ways to do it -- would love to get help, give access, ownership wherever needed. |
I was thinking about potentially just using Gradle as the cross-version testing tool, but leaving all your publishing infrastructure in place using Maven. I don't really want to mess with that personally. |
PR Here: #534 |
This issue is closed because |
@k163377 Kotlin module still officially supports Kotlin 1.4 as per README; at least for Jackson 2.14. But if we decide explicitly NOT to support it, we should probably indicate this in README (wrt 2.15.0), as well as in main Jackson 2.15 release notes: https:/FasterXML/jackson/wiki/Jackson-Release-2.15 And also, if so, remove testing against Kotlin-core 1.4 in matrix build for CI. I have no strong feeling wrt this, but I think we'd need to:
I don't expect this to be very controversial, but there should be a decision to do that since it seems like Kotlin 1.4 is still nominally supported. |
Created #632 for official dropping of support; sent an email to |
I closed this because it is not practical to work on fixing issues related to the already deprecated |
@k163377 I have no objections to closing the issue, or deprecating support -- but what I meant was that this module HASN'T yet (at least officially) dropped Kotlin 1.4 support. But I think we should. Put another way: it's all good; I hope we can make everything align here so that Kotlin 1.4 (which is unsupported by its creators, right?) is also no longer supported by new versions of Jackson Kotlin module. Anyway: I think it's good finding at any rate. There has been discussion about support level, but no decisions. No we should be able to decide. |
…n serializer. Had to downgrade kotlin version to 2.12.0. Bugfix thread: FasterXML/jackson-module-kotlin#523
I hope to support both Java and kolitin in my project, but Jackson module kotlin is introduced into my POM. In the Java environment, this package will report errors
The text was updated successfully, but these errors were encountered: