Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to load local fonts #30

Open
lab360-ch opened this issue May 6, 2022 · 6 comments
Open

Failed to load local fonts #30

lab360-ch opened this issue May 6, 2022 · 6 comments

Comments

@lab360-ch
Copy link

lab360-ch commented May 6, 2022

Lately, Figma tries to load the local fonts with an additional query parameter freetype_minimum_api_version.

Here is an example of the request URL: http://127.0.0.1:18412/figma/font-file?file=<font_path>&freetype_minimum_api_version=20

In the current Implementation, additional query parameters are not handled.

I implemented a simple parsing of the query parameters to fix this issue in the Pull request #29.

Hopefully this pull request gets accepted, that this cool service will work again.

Best regards and thanks to the creator of this project

@louispotok
Copy link

Thank you @lab360-ch for the fix and @ChugunovRoman for the quick merge! If anyone else sees this, note that this won't fix the version that is installed because (as of now) there is not a new latest release.

I forked and created a new release, so if you just want to install the new version you can download the install.sh script according to the README instructions and just s/RomanChugunov/louispotok (in 2 places) before running it, and it should work.

@huzaifahj
Copy link

huzaifahj commented May 14, 2022

@louispotok I've tried installing your 0.1.6 release but things still aren't working for me. When I do /opt/FontHelper/fonthelper -v I still get 0.1.5 and the http://127.0.0.1:18412/figma/font-file request works when I remove the freetype_minimum_api_version query param.

Any suggestions? I disabled the old service first, deleted all the files from the installation and then installed your version.

@kextextension
Copy link

@louispotok can you help? its really confusing reading your reply "and just s/RomanChugunov/louispotok (in 2 places) before running", and it made me stuck on how to install it :/

@huzaifahj
Copy link

@louispotok can you help? its really confusing reading your reply "and just s/RomanChugunov/louispotok (in 2 places) before running", and it made me stuck on how to install it :/

By that he means, in the install.sh file, replace RomanChugunov with louispotok. You'll need to do it in 2 places within that file.

Still isn't working for me after I do that though

@louispotok
Copy link

louispotok commented May 20, 2022

@huzaifahj
I forgot a few things the first go-around:

  1. Didn't update version number in Cargo.toml
  2. Didn't update the urls in res/updater.sh, so the auto-updates were pulling the latest version from the old repo!

Both should be fixed, try again!
curl -L https://raw.githubusercontent.com/louispotok/figma-linux-font-helper/master/res/install.sh | bash

@kextextension
Copy link

@huzaifahj I forgot a few things the first go-around:

  1. Didn't update version number in Cargo.toml
  2. Didn't update the urls in res/updater.sh, so the auto-updates were pulling the latest version from the old repo!

Both should be fixed, try again! curl -L https://raw.githubusercontent.com/louispotok/figma-linux-font-helper/master/res/install.sh | bash

FINALLY IT WORKS TYSMM!!! :DDDDDDDD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants