Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci-2159 remove html-to-text package #56

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

debugwand
Copy link
Contributor

No description provided.

@debugwand debugwand requested a review from a team as a code owner May 3, 2024 09:43
});
expect(result.description).to.equal("Hello I'm HTML!");
});
// TODO: https://financialtimes.atlassian.net/browse/CI-2226 reinstate summary
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debugwand this should not needed anymore with cp-pipeline. It relates to the part here

Suggested change
// TODO: https://financialtimes.atlassian.net/browse/CI-2226 reinstate summary

We can assume that will eventually be implemented also in FT-App in the same way. Please close the ticket, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that the bit that updates what is visible in the page though? this is for the metadata in JSON LD

Currently
Screenshot 2024-05-03 at 15 31 49

it no longer has the metadata about the links that would look like this, that goes after the end of the entry about the image
"liveBlogUpdate":[{"@type":"BlogPosting","headline":"US LNG pioneer Souki leaves top job at Tellurian","datePublished":"2023-12-08T23:40:41.160Z","dateModified":"2023-12-08T23:40:41.160Z"},{"@type":"BlogPosting","headline":"US stocks hit 20-month high as S&P 500 notches longest weekly win streak in 4 years","datePublished":"2023-12-08T21:38:21.810Z","dateModified":"2023-12-08T21:38:21.810Z"},{"@type":"BlogPosting","headline":"US vetoes UN resolution demanding Gaza ceasefire","datePublished":"2023-12-08T21:16:24.252Z","dateModified":"2023-12-08T21:16:24.252Z"},{"@type":"BlogPosting","headline":"Treasuries sell off after strong jobs report surprises traders","datePublished":"2023-12-08T19:16:06.751Z","dateModified":"2023-12-08T19:16:06.751Z"}, etc.etc.

(full paste of old and current outputs are in https://financialtimes.atlassian.net/browse/CI-2226)

@debugwand debugwand merged commit 61f769b into main May 9, 2024
8 checks passed
@debugwand debugwand deleted the ci-2159-security branch May 9, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants