New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devtools/update_changelog.sh #164

Closed

loloicci opened this issue Mar 2, 2022 · 1 comment · Fixed by #170

Assignees

Contributor

loloicci commented Mar 2, 2022

devtools/update_changelog.sh issues URL like https://gitub.com/line/cosmwasm/issues/XXX. But https://gitub.com/line/cosmwasm/pull/XXX is correct (issues vs pull).
When we merge with a merge commit, all commits start with a prefix like "feat:" are included in CHANGELOG. Should filter commits without PR numbers.

Contributor Author

loloicci commented Mar 4, 2022 •

edited

Loading

devtools/update_changelog.sh issues URL like https://gitub.com/line/cosmwasm/issues/XXX. But https://gitub.com/line/cosmwasm/pull/XXX is correct (issues vs pull).

This URL is generated by simply replacing texts in commit title from (#XXX) to ([#XXX](https://brabra)) in chglog. ~~So it is unable to distinguish issues and PRs.~~ We can replace it with regex in template file.

loloicci self-assigned this

loloicci mentioned this issue

fix: modify the chglog template to filter commits and correct PRs' URL #170

Merged

8 tasks

loloicci closed this as completed in #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment