Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update query-queue to version 1.0.0 #203

Merged
merged 3 commits into from
Jun 3, 2022
Merged

fix: update query-queue to version 1.0.0 #203

merged 3 commits into from
Jun 3, 2022

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Jun 3, 2022 •
edited
Loading

Description

  • update gas_limit to follow vm v1.0.0
  • update how to query raw to follow queue v1.0.0
  • change the result format of raw_query

This fixes #202

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci
fix: update query-queue to version 1.0.0
164f537 
- update gas_limit to follow vm v1.0.0
- update how to query raw to follow queue v1.0.0
@loloicci loloicci self-assigned this Jun 3, 2022
@zemyblue
Copy link
Member

zemyblue commented Jun 3, 2022

@loloicci , The CI action of query_queue contract still failed.

@loloicci
Copy link
Contributor Author

loloicci commented Jun 3, 2022 •
edited
Loading

The CI action of query_queue contract still failed.

Sorry, it has not included Cargo.lock and schema JSONs. I pushed them.

@loloicci loloicci requested a review from zemyblue June 3, 2022 05:17
zemyblue
zemyblue approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci mentioned this pull request Jun 3, 2022
Merged
8 tasks
shiki-tak
shiki-tak approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit 51f479a into Finschia:main Jun 3, 2022
@zemyblue zemyblue mentioned this pull request Jun 3, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@shiki-tak shiki-tak shiki-tak approved these changes

Assignees

@loloicci loloicci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration tests for query-queue issue errors with v1.0.0-0.6.0
3 participants
@loloicci @zemyblue @shiki-tak