feat: add approve, burn_from, transfer_from #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiki-tak
commented
Nov 13, 2020
| @@ -623,9 +622,6 @@ jobs: | |||
| name: Unit tests | |||
| env: RUST_BACKTRACE=1 | |||
| command: cargo unit-test --locked | |||
| - run: | |||
| name: Integration tests | |||
There was a problem hiding this comment.
As the file for the integration test does not exist, I removed it once as it was an error.
loloicci
approved these changes
Nov 17, 2020
brew0722
reviewed
Nov 18, 2020
| @@ -525,7 +525,7 @@ mod tests { | |||
| fn create_contract(owner: String) -> (Extern<MockStorage, MockApi, MockQuerier>, Env) { | |||
| let mut deps = mock_dependencies(20, &coins(1000, "cony")); | |||
| let env = mock_env(owner, &coins(1000, "cony")); | |||
| let res = init(&mut deps, env, InitMsg {}).unwrap(); | |||
| let res = init(&mut deps, env.clone(), InitMsg {}).unwrap(); | |||
There was a problem hiding this comment.
create_contract finally specifies env as a return value.
If you don't pass it to init function with a clone, the ownership will be moved and you'll get a build error.
whylee259
approved these changes
Nov 18, 2020
brew0722
approved these changes
Nov 19, 2020
loloicci
pushed a commit
that referenced
this pull request
Jan 26, 2021
* feat: add approve, burn_from, transfer_from * fix: config.yml * fix: update schema * fix: msg name * fix: update schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #28
Description
I added approve, burn_from, transfer_from for token encode library.
The test is run with the https:/line/link-modules/pull/42.
Motivation and context
How has this been tested?
Checklist: