Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add the description of versioning rule #330

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

da1suk8
Copy link
Member

@da1suk8 da1suk8 commented Oct 13, 2023

Description

Added the description of versioning rule.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

To explain our versiong rule
@da1suk8 da1suk8 self-assigned this Oct 13, 2023
@da1suk8 da1suk8 marked this pull request as ready for review October 13, 2023 07:25
CONTRIBUTING.md Outdated Show resolved Hide resolved
- reversed Y.Y.Y and ZZZ
- added additional information
- reversed Z.Z.Z and YYY
-  fix explanation
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog

@zemyblue zemyblue self-requested a review October 26, 2023 02:27
@da1suk8
Copy link
Member Author

da1suk8 commented Oct 26, 2023

@zemyblue

In cosmwasm, CHANGELOG is generated automatically and does not need to be added.

@zemyblue
Copy link
Member

@zemyblue

In cosmwasm, CHANGELOG is generated automatically and does not need to be added.

If then, what's this?
https:/Finschia/cosmwasm/blob/main/CHANGELOG.md

These changes are written automatically?

@da1suk8
Copy link
Member Author

da1suk8 commented Oct 26, 2023

@zemyblue

This is used to create the CHANGELOG.

However, it does not seem to have been updated since 0.16.3-0.5.1, so will create another PR with CHANGELOG updated.

@da1suk8 da1suk8 merged commit 7981317 into Finschia:main Nov 6, 2023
21 checks passed
@da1suk8 da1suk8 deleted the doc/versioning_rule branch November 6, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants