Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add CHANGELOG-ours.md for v0.12.0-0.1.0 #62

Merged
merged 2 commits into from
Jan 22, 2021
Merged

docs: Add CHANGELOG-ours.md for v0.12.0-0.1.0 #62

merged 2 commits into from
Jan 22, 2021

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Jan 19, 2021 •
edited
Loading

part of #34

Description

Add CHANGELOG-ours.md CHANGELOG-LINK.md for v0.12.0-0.1.0.
After merging this, we merge develop into master and add tag v0.12.0-0.1.0

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly. (NOT NEEDED)
  • I have added tests to cover my changes. (NOT NEEDED)

@loloicci loloicci added the documentation Improvements or additions to documentation label Jan 19, 2021
@loloicci loloicci self-assigned this Jan 19, 2021
@loloicci loloicci changed the title add CHANGELOG-ours.md for v0.12.0-0.1.0 docs: Add CHANGELOG-ours.md for v0.12.0-0.1.0 Jan 19, 2021
brew0722
brew0722 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@brew0722 brew0722 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, btw, How about changing 'our' in the file name to 'LINK'?

@loloicci
Copy link
Contributor Author

How about changing 'our' in the file name to 'LINK'?

Sounds like a good idea.
How do you think, other reviewers?

@shiki-tak
Copy link
Contributor

How about changing 'our' in the file name to 'LINK'?

Sounds like a good idea.
How do you think, other reviewers?

I agree with you.

@loloicci loloicci merged commit 1f120d7 into Finschia:develop Jan 22, 2021
loloicci added a commit that referenced this pull request Jan 26, 2021
@loloicci
docs: Add CHANGELOG-ours.md for v0.12.0-0.1.0 (#62)
0447d3a 
* docs: Add CHANGELOG-ours.md for v0.12.0-0.1.0

* docs: rename and add a note in CHANGELOG-LINK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiki-tak shiki-tak shiki-tak approved these changes

@brew0722 brew0722 brew0722 approved these changes

@whylee259 whylee259 Awaiting requested review from whylee259

Assignees

@loloicci loloicci

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loloicci @shiki-tak @brew0722