feat: Implement collection wrapper library and complete collection tester #8
+5,019
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loloicci
reviewed
Nov 6, 2020
contracts/collection-tester/NOTICE
Outdated
| @@ -0,0 +1,14 @@ | |||
| CW20-Base: A reference implementation for fungible token on CosmWasm | |||
| ``` | ||
| ~/dev/link-cosmwasm-bindings master* | ||
| ❯ pwd | ||
| /Users/JP24217/dev/link-cosmwasm-bindings |
| @@ -0,0 +1,45 @@ | |||
| # LINK bindings CosmWasm tester contract | |||
There was a problem hiding this comment.
Originally, this is the README for a separate repository(link-cosmwasm-bindings).
Because there is also a schema, as a README of the procedure of the command, I thought there was no need to prepare here, so I remove it.
whylee259
reviewed
Nov 6, 2020
.circleci/config.yml
Outdated
| command: rustc --version; cargo --version; rustup --version; rustup target list --installed | ||
| - restore_cache: | ||
| keys: | ||
| - cargocache-v2-package_std-rust:1.44.1-{{ checksum "Cargo.lock" }} |
There was a problem hiding this comment.
I think this branch should be rebased or merged from the develop.
There was a problem hiding this comment.
Yes, as I mentioned in the comments, I'll rebase PR#7 once it's merged.
.circleci/config.yml
Outdated
| @@ -491,6 +551,54 @@ jobs: | |||
| - target/wasm32-unknown-unknown/release/build | |||
| - target/wasm32-unknown-unknown/release/deps | |||
| key: cargocache-v2-contract_staking-rust:1.44.1-{{ checksum "Cargo.lock" }} | |||
| contract_token_tester: | |||
There was a problem hiding this comment.
Isn't it needed contract_collection_tester job also?
loloicci
reviewed
Nov 6, 2020
| } | ||
|
|
||
| #[derive(Serialize, Deserialize, Clone, Debug, PartialEq, JsonSchema)] | ||
| #[serde(rename_all = "snake_case")] |
There was a problem hiding this comment.
Does not #[serde(untagged)] needed?
whylee259
approved these changes
Nov 10, 2020
loloicci
approved these changes
Nov 10, 2020
loloicci
pushed a commit
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4
Description
This PR should be merged after #7 has been merged.
After PR#7 is merged, I'll combine the commits into one, so things like circleci config and token wrapper are removed from the changed files.
Motivation and context
How has this been tested?
Checklist: