Fetch artifacts in parallel. Treat warnings as errors #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winterDroid
reviewed
Nov 2, 2018
| downloadFile.parent.toFile().mkdirs() | ||
| blob.downloadTo(downloadFile) | ||
| runBlocking { | ||
| filtered.forEach { matrix -> |
There was a problem hiding this comment.
should the amount of parallel executions be limited?
There was a problem hiding this comment.
with the current code, there's one parallel execution per matrix that's finished & not yet downloaded.
I don't think this will be a problem. The download requests for each matrix are still run synchronously.
if it is an issue then we could look into placing an upper limit on the amount of concurrency.
There was a problem hiding this comment.
If the property is not specified,
Runtime.getRuntime().availableProcessors() - 1will be used
based on the above, looks like we're good
sravanmedarapu
pushed a commit
to sravanmedarapu/flank
that referenced
this pull request
Nov 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #323