Fix incorrect way of turning CMAKE_INSTALL_LIBDIR absolute #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR} is not guaranteed to make sense
because CMAKE_INSTALL_LIBDIR may be specified as an absolute path, in which case
this concatenation is nonsense.
Use CMAKE_INSTALL_FULL_LIBDIR instead, which will use CMAKE_INSTALL_LIBDIR if
it's already absolute, or concatenate it onto CMAKE_INSTALL_PREFIX if it isn't.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks! |
mikelow
added a commit
to mikelow/fluidsynth
that referenced
this pull request
Jul 13, 2023
Fix incorrect way of turning CMAKE_INSTALL_LIBDIR absolute (FluidSynth#1261)
DominusExult
added a commit
to DominusExult/fluidsynth-sans-glib
that referenced
this pull request
Mar 6, 2024
* commit '683270db64302e59d26b9610514af1cfe0a80493': Bump to 2.3.5 Fix libinstpatch and sndfile not being discovered on Windows (FluidSynth#1299) Update FreeBSD CI: Drop 12.4 and add 14.0 Fix some rounding issues due to double promotion (FluidSynth#1286) Bump to 2.3.4 Fix player termination after stopping and restarting (FluidSynth#1273) fix for issue FluidSynth#1268: Pipewire's Jack implementation not found (FluidSynth#1269) Fix issue with CMake Xcode generator (FluidSynth#1266) Refurbish CI (FluidSynth#1267) Fallback to IPv4 when creating socket if IPv6 is not available (FluidSynth#1208) (FluidSynth#1265) Turn off pending notes and issue a warning (FluidSynth#1264) Fix incorrect way of turning CMAKE_INSTALL_LIBDIR absolute (FluidSynth#1261)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}is not guaranteed to make sense becauseCMAKE_INSTALL_LIBDIRmay be specified as an absolute path, in which case this concatenation is nonsense.Use
CMAKE_INSTALL_FULL_LIBDIRinstead, which will useCMAKE_INSTALL_LIBDIRif it's already absolute, or concatenate it ontoCMAKE_INSTALL_PREFIXif it isn't.