Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loop mode release #1400

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

spessasus
Copy link
Contributor

Adds support for the new "sample mode release" introduced by Polyphone 2.4

Resolves #1398

@spessasus spessasus changed the title Add support for soop mode release Add support for loop mode release Oct 8, 2024
Copy link

sonarcloud bot commented Oct 8, 2024

Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: This is only my personal static code analysis - I haven't tested this yet.

IMO, the change is inaccurate because for two reasons:

  • You're not implementing the 0.02s attack phase.
  • Polyphone claims that the "playback begins with the release phase". But you implemented it in such a way that the voice plays back silently until the release phase begins (because of the dsp updates happening just before that). This behavior would be pretty equivalent to the delay phase, but I don't think this is the intended behavior by Polyphone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for sample mode release
2 participants