pedantic clippy fixes except must_use

src/deserialize.rs

@@ -127,7 +127,7 @@ impl TryFrom<PassDef> for Pass {
  fn try_from(value: PassDef) -> Result<Self, Self::Error> {
  let mut rules = value.rules.0;
 
- for rule in rules.iter_mut() {
+ for rule in &mut rules {
  rule.0 = runtime_format_single_value(&value.format, &rule.0)?;
  }
 

src/intensity.rs

@@ -23,7 +23,7 @@ impl Intensity {
  for new_pass in passes {
  let mut replaced = false;
 
- for existing_pass in existing_passes.iter_mut() {
+ for existing_pass in &mut existing_passes {
  if existing_pass.name == new_pass.name {
  // FIXME: remove clone
  *existing_pass = existing_pass.extend(new_pass.clone())?;

src/pass.rs

@@ -89,7 +89,7 @@ impl Pass {
  for (new_regex, new_tag) in other.regexes.into_iter().zip(other.tags.into_iter()) {
  let mut replaced = false;
 
- for (existing_regex, existing_tag) in existing_rules.iter_mut() {
+ for (existing_regex, existing_tag) in &mut existing_rules {
  if &new_regex == existing_regex {
  // FIXME: remove clone
  *existing_tag = new_tag.clone();

src/utils.rs

@@ -30,8 +30,8 @@ impl PartialEq for LiteralString {
 fn case(char_count: usize, string: &str) -> (bool, bool, bool) {
  let (lower, upper) = string.chars().fold((0, 0), |(lower, upper), c| {
  (
- lower + c.is_ascii_lowercase() as usize,
- upper + c.is_ascii_uppercase() as usize,
+ lower + usize::from(c.is_ascii_lowercase()),
+ upper + usize::from(c.is_ascii_uppercase()),
  )
  });
 
@@ -90,13 +90,13 @@ impl LiteralString {
 
  for (i, c_old) in source.chars().enumerate() {
  if c_old.is_ascii_lowercase() {
- body.get_mut(i..i + 1)
+ body.get_mut(i..=i)
  .expect("strings have same len")
- .make_ascii_lowercase()
+ .make_ascii_lowercase();
  } else if c_old.is_ascii_uppercase() {
- body.get_mut(i..i + 1)
+ body.get_mut(i..=i)
  .expect("strings have same len")
- .make_ascii_uppercase()
+ .make_ascii_uppercase();
  }
  }