Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate a nav-pills issue #60

Open
Carl-Hugo opened this issue Nov 17, 2022 · 0 comments
Open

Investigate a nav-pills issue #60

Carl-Hugo opened this issue Nov 17, 2022 · 0 comments

Comments

@Carl-Hugo
Copy link
Member

    Sorry to bother you again, sir, but you missed my first bug report:
.nav-pills .nav-link.active, .nav-pills .show>.nav-link {
    color: #fff;
    background-color: _is_used_from_light_theme_
}

Try to change color in light theme (in node modules to red). And check nav-pills in dark theme.
For example, this code:

<ul class="nav nav-pills nav-fill">
  <li class="nav-item">
    <a class="nav-link active" href="#">Active</a>
  </li>
  <li class="nav-item">
    <a class="nav-link" href="#">Much longer nav link</a>
  </li>
  <li class="nav-item">
    <a class="nav-link" href="#">Link</a>
  </li>
  <li class="nav-item">
    <a class="nav-link disabled">Disabled</a>
  </li>
</ul>

Again, I don't need this, but it would be responsible to fix obvious bugs.
Furthermore, I think you should add nav-pills code https://getbootstrap.com/docs/4.6/components/navs/ to your samples

Have a nice day!

Originally posted by @AucT in #57 (comment)

@Carl-Hugo Carl-Hugo changed the title Investigate a nav-link issue Investigate a nav-pills issue Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant