Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vJoyDrv button on SD+ dial does not trigger button press #70

Open
pre-martin opened this issue Sep 23, 2024 · 8 comments
Open

vJoyDrv button on SD+ dial does not trigger button press #70

pre-martin opened this issue Sep 23, 2024 · 8 comments

Comments

@pre-martin
Copy link

This issue affects the current master (development) version.

When a VJoyDrv button is assigned to a SD+ dial, there is no button pressed. Only if you rotate the dial fast enough, so that the Stream Deck software reports abs(ticks) > 1, the PilotsDeck plugin will trigger a joystick button press.

The reason is that

return VirtualJoystick.ClearSetDriverButton(command.Address, command.IsDown);
always calls ClearSetDriverButton(..., false). Only with ticks > 1 the code starts to send true followed by false.

@Fragtality
Copy link
Owner

Good catch!

How does the latest Build work out?

Since you have a Use-Case for such a Combo, please also test if it both works with the Composite Actions and the "Classic" Actions!

@pre-martin
Copy link
Author

Thank you, it works again with the "Display Value" action.

I will make more tests later.

@pre-martin
Copy link
Author

Works also with all other actions. Also with the Composite action. 👍

Two remarks (not related to this ticket, but to your plugin):

  • The support of LUA scripts directly from the plugin is mind blowing. For example, all my EFIS buttons for the FBW A32NX are dimmed when there is no AC power on the aircraft. Or the baro on the SD+ dial displays "88.88" during the lights test.
  • Composite actions are also awesome. I am just about to discover the endless possibilities of this feature.

@Fragtality
Copy link
Owner

Thanks for the Feedback ❤️
It's always great to know that the Work and the Ideas behind it are recognized!

The funny Thing about the two new Features you mentioned: I got rid of most Scripts for the FCU/AP-Panels since the Composite Action can handle the simple Logics for that on its own (for Example on the A32NX) ^^

@pre-martin
Copy link
Author

Unfortunately I did not test "dial press" after your fix. "dial left" and "dial right" work perfectly, but on dial press, the joystick buttons remains pressed forever.

@Fragtality
Copy link
Owner

Nope, works.

@pre-martin
Copy link
Author

If I put the same vJoy button (e.g. 1:10) on both "DIAL_DOWN" and "DIAL_UP" of the Composite Action, it works. If I only put 1:10 on "DIAL_DOWN" the joystick button is never released. The documentation says:

Non-Toggling vJoy Buttons will behave like any normal Joystick Button - they are down/set as long as the StreamDeck Key/Dial is down (and go up/cleared when the Key/Dial goes up again).

@Fragtality
Copy link
Owner

Ohhhh - that Part must be reformulated! D'OH

Yes that is true for the "classic" Actions, not for the Composite Action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants