try-catch block added to KeepAliveThread::Run() #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exception thrown in KeepAliveThread::Run() cannot be caught in client application and cause app crash when OPC-UA connection is drop. Adding try-catch block avoid this and gives client app opportunity to create new OPC-UA connection without crash.
With newer versions of GCC, the error: ‘for_each’ is not a member of ‘std’ is triggered unless the algorithm header from std lib is included.
Include algorithm header in model_impl.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exception thrown in KeepAliveThread::Run() cannot be caught in client
application and cause app crash when OPC-UA connection is drop. Adding
try-catch block avoid this and gives client app opportunity to create
new OPC-UA connection without crash.