Fixed function signature in Node
#1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a function signature of `read_array_dimensions` in asyncua/common/node. ArrayDimentions is always a list of ints because OPC UA has support for multidimentional arrays. But the return type was is specified as int.
|
thanks, unfortunately we still have many of these wrong typing things.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed function signature of
read_array_dimensionsin asyncua/common/node.ArrayDimentions is always a
listofints because OPC UA has support for multidimentional arrays. This is specified in the OPC UA standard at the end of this page. But the return type in asyncua was is specified asint. This can generate false type-checker errors. Fix is to just change signature. The fucntion already correctly returns a list of integers.Let me know if you want me to add a changelog entry also 😊