Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow deep link to extension configuration #5449

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Allow deep link to extension configuration #5449

merged 5 commits into from
Jun 13, 2023

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Jun 9, 2023 •
edited
Loading

Allow a full screen view of an extension configuration, with a deep-link URL.
Example:
image

Background: I have a use-case for which I need to provide a direct link to an extension configuration page.

@Alkarex Alkarex added UI 🎨 User Interfaces Extension 🔌 labels Jun 9, 2023
@Alkarex Alkarex added this to the 1.22.0 milestone Jun 9, 2023
@Alkarex
Copy link
Member Author

Alkarex commented Jun 9, 2023 •
edited
Loading

For those working with extensions, could you please double-check that it does not break your use-cases?

@math-GH
Copy link
Contributor

math-GH commented Jun 9, 2023

There is a bug:

  1. go to extension config page
  2. open the settings of a extension, f.e. CustomCSS (the slider will be opened)
  3. save the settings

expected: the slider will be shown as slider or closed.
What is visible: The settings will be opened in full screen

@Alkarex
Copy link
Member Author

Alkarex commented Jun 11, 2023

What about now @math-GH ?

@math-GH
Copy link
Contributor

math-GH commented Jun 12, 2023

Additional question:
If you open the config in a new tab, than the new tab has no navigation on the left hand side. Is it on purpose?
Compared to the feed configuration, where the left navigation is given in a new tab

@Alkarex
Copy link
Member Author

Alkarex commented Jun 12, 2023

Additional question:
If you open the config in a new tab, than the new tab has no navigation on the left hand side. Is it on purpose?
Compared to the feed configuration, where the left navigation is given in a new tab

No, good point, it was not on purpose

@Alkarex
Copy link
Member Author

Alkarex commented Jun 13, 2023

@math-GH Done d546aff

@math-GH
Copy link
Contributor

math-GH commented Jun 13, 2023

Please double check: Does it make sense in the "full screen mode" (extension configs in new tab opened), that the config page will no be closed, when clicking the submit button?

@Alkarex
Copy link
Member Author

Alkarex commented Jun 13, 2023

Does it make sense in the "full screen mode" (extension configs in new tab opened), that the config page will no be closed, when clicking the submit button?

Do you mean automatically closing the window/tab (if so, then no: in my case, it is the main window, not a new tab; and in other cases, I only think this should be done for modal windows, not tabs), or redirecting to another page after submission (if so, I do not really mind, but I find it fine as it is now)

@math-GH
Copy link
Contributor

math-GH commented Jun 13, 2023

fine for me too

@Alkarex Alkarex merged commit 3fe68a3 into FreshRSS:edge Jun 13, 2023
@Alkarex Alkarex deleted the full-page-extension-configuration branch June 13, 2023 20:40
@math-GH
Copy link
Contributor

math-GH commented Jun 13, 2023

@Alkarex I found one thing after it was merged: The <title> is just the default FreshRSS. It would be better to have the title of the extension in the tab.

Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Jun 14, 2023
@Alkarex
Fix slider titles
4f99449 
And fix full-page view of category configuration.
FIx FreshRSS#5449 (comment)
@Alkarex Alkarex mentioned this pull request Jun 14, 2023
Merged
@Alkarex
Copy link
Member Author

Alkarex commented Jun 14, 2023

@Alkarex I found one thing after it was merged: The <title> is just the default FreshRSS. It would be better to have the title of the extension in the tab.

Done in #5469

Alkarex added a commit that referenced this pull request Jun 15, 2023
@Alkarex
Fix slider views (#5469)
228d7ad 
* Fix slider titles
And fix full-page view of category configuration.
FIx #5449 (comment)

* Fix user queries and user management
Implement #5469 (comment)
math-GH pushed a commit to math-GH/FreshRSS that referenced this pull request Jul 4, 2023
@Alkarex @math-GH
Allow deep link to extension configuration (FreshRSS#5449)
f9b401f 
* Allow deep link to extension configuration
Full screen

* Support slider

* Add aside_configure
Fix FreshRSS#5449 (comment)
Alkarex added a commit that referenced this pull request Jul 8, 2024
@math-GH @ColonelMoutarde
@Alkarex @aledeg @vrachnis @LleanaRuv @acbgbca @Alwaysin @yubiuser @aaronschif
Improve aside feed bar (#6446)
5a5ccc9 
* delete theme BlueLagoon

* delete theme Screwdriver

* phpstan level 7 for feedController.php (#5373)

* phpstan level 7 for feedController.php

* phpstan level 7 for feedController.php

* phpstan level 7 for feedController.php

* phpstan level 7 for feedController.php

* A few fixes

---------

Co-authored-by: Luc <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>

* phpstan level 7 for updateController.php (#5376)

* phpstan level 7 for updateController.php

* phpstan level 7 for updateController.php

* Minor array syntax

---------

Co-authored-by: Luc <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>

* docs: language table added (#5375)

* docs: language table added

* Update 05_Configuration.md

* Update 05_Configuration.md

* french docs

* Unicode quote and a few fixes
(Same search&replace aslo applied to a few other files)

---------

Co-authored-by: Alexandre Alapetite <[email protected]>

* Share in anonymous mode (#5261)

#fix #5248

Co-authored-by: maTh <[email protected]>

* Minor development config fixes (#5379)

* Add compatibility with MacOS for `paste` command
* Addition to .editorconfig

* Fix markAsReadUponGone (#5382)

Fix regression from #5315
which indroduced a bug for cached feeds.
We now update the `lastSeen` property of entries to account for the fact that they are unchanged but still existing.

* phpstan level 7 for indexController.php (#5384)

Co-authored-by: Luc <[email protected]>

* Improved: "Mark an article as read…" text area. Added a link to the documentation (#5349)

* i18n

* Update sub.php

* Update app/i18n/fr/sub.php

Co-authored-by: Alexandre Alapetite <[email protected]>

* fix target="_blank"

---------

Co-authored-by: Alexandre Alapetite <[email protected]>

* Update Docker image Alpine 3.18 (#5383)

https://alpinelinux.org/posts/Alpine-3.18.0-released.html

Minor updates with Apache 2.4.57 and PHP 8.1.19

* Docs: delete 04_Changing_source_code.md (#5391)

* delete 04_Changing_source_code.md

* make pot

---------

Co-authored-by: Alexandre Alapetite <[email protected]>

* Typed view model classes (#5380)

* Typed view model classes
* Add ability to provide a typed view model class to a controller
* Use `::class` instead of string for referring to classes
* Examplified with `stats` and `javascript` controllers / views (more to do)
* Also useful for extensions (my usecase today), which did not have the ability to define own view model attributes before.

* Typo

* A few additional PHPStan rules (#5388)

A subset of
https:/phpstan/phpstan-strict-rules

* Improved: Install process: give more infos (#5350)

* comments added for each step

* infos about FreshRSS added in first step

* Remove reference to Kriss and Leed from install page
I do not find that informative, and quite confusing. Moved to readme instead.

---------

Co-authored-by: Alexandre Alapetite <[email protected]>

* PHPMailer 6.8.0 (#5389)

* PHPMailer 6.8.0
https:/PHPMailer/PHPMailer/releases/tag/v6.8.0
https:/PHPMailer/PHPMailer/releases

* Exclude unused DSNConfigurator

* fix: docs: array syntax (#5392)

* Link configuration to proper parameter (#5394)

Before, the system configuration was linked to the user parameter while the
user configuration was linked to the system parameter. This was an issue when
trying to retrieve some kind of configuration value in an extension.
Now, the configurations are properly linked to their parameters.

* PHPStan Level 7 for Share userController logs_pagination (#5393)

* fix: "for" attribute in config display (#5398)

* move darkMode_auto from body to html root (#5397)

* CSS: refactor of a.btn (#5401)

* Fix logs pagination (#5403)

* Fix logs pagination
Regression from #5269

* Add better default

* PHPStan Level 7 for Minz_Request, FreshRSS_Feed, Minz_Error (#5400)

* PHPStan Level 7 for Minz_Request

* PHPStan Level 7 for FreshRSS_Feed

* PHPStan Level 7 for Minz_Error

* Fix again updateLastSeenUnchanged (#5404)

* Fix again updateLastSeenUnchanged
#5382 was not good enough to fix markAsReadUponGone and introduced a regression in `entry.lastSeen`.
New approach.
Follow-up of #5315

* Minor change of mind

* Fix handling of lastSeen
entry.lastSeen was not always correctly initialised, and sometimes overriden

* Remove debug line
Forgotten from #5404

* Avoid falsy guid (#5412)

Whitespace strings, empty strings, 0 are all problematic when working with GUIDs. so avoid them.

* PHPStan Level 7 complete (#5406)

* PHPStan Level 7 complete

* Start PHPStan Level 8

* Forgot exclude .phtml

* Fix favicon fetching while using proxies (#5421)

* Fix favicon fetching while using proxies

This ensures that if curl_options are defined in config.php, those
settings are respected while fetching favicons.

Fixes #4951

* Change options priority

* Credits keep alphabticorder

---------

Co-authored-by: Alexandre Alapetite <[email protected]>

* Fixed: i18n extensions: 'en' as fallback (#5426)

* Update Translate.php

* Small improvements

---------

Co-authored-by: Alexandre Alapetite <[email protected]>

* Improve Dev Container (#5423)

* Improve Dev Container
PHPStan was failing in Dev Container

* Update Docker to Alpine Linux 3.18
* New DATA_PATH environment variable

* README

* Update of Spanish translation (#5408)

* Update admin.php

Update Spanish

* Update conf.php

Spanish update

* Fix

---------

Co-authored-by: Alexandre Alapetite <[email protected]>

* Linkding share now passes title #5432 (#5433)

* phpstan-8 typehinting (#5429)

Co-authored-by: Luc <[email protected]>

* Forgotten debug line
#5404

* phpstan-9 for Share.php (#5431)

* phpstan 9 for Search.php
phpstan 9 for Share.php

* phpstan-9 for Search.php

* Better consistency for search results

---------

Co-authored-by: Luc <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>

* Pull request of spanish translation (#5436)

* Update sub.php

Update spanish translation

* Update conf.php

Update Spanish translation

* Update gen.php

Update spanish translation

* Update index.php

Update spanish translation

* Update admin.php

update spanish translation

* Fix ignore

---------

Co-authored-by: Alexandre Alapetite <[email protected]>

* improved background colors (#5437)

* phpstan-8 for category class (#5434)

* phpstan-8 for category class

* Another approach to nullable
#5434 (comment)

---------

Co-authored-by: Luc <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>

* Docker example of PostgreSQL tuning (#5446)

Provide example of how to easily tune selected PostgreSQL settings
https://wiki.postgresql.org/wiki/Tuning_Your_PostgreSQL_Server

* Update SECURITY.md (#5448)

Link to GitHub security advisory process + PGP key

* fix: new article banner in Ansum/mapco theme (#5453)

* fix

* rtl

* Update dark theme css to lower brightness to all icons (#5439)

* Update dark.css to lower brightness to all icons

* Update dark.rtl.css to lower brightness to all icons

* re-add p.help .icon

* re-add p.help .icon

* Remove core extensions Google Groups and Tumblr (#5457)

* Remove core extensions Google Groups and Tumblr
* Google Groups seems to have remove support for RSS/ATOM #2838 (see e.g. https://www.theregister.com/2021/08/16/google_groups_rss/ )
* Tumblr seems to have fixed their RSS/ATOM post-GDPR #1924

So for both of thems, the extensions have become irrelevant.

* Cleaning

* Clarify that maximum number to keep is per feed (#5458)

* Clarify that maximum number to keep is per feed

Signed-off-by: Christian König <[email protected]>

* Append //DIRTY

Signed-off-by: Christian König <[email protected]>

* make fix-all

* Revert wrong whitespace

* Amend Credits.md

Signed-off-by: Christian König <[email protected]>

---------

Signed-off-by: Christian König <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>

* Add OpenID Connect (#5351)

* Add OIDC

* Update documentation.

* Update apache conf adding IfModule

* Use IfDefine for OIDC in apache conf

* Fix non-oidc support

* Fix typing

* Use IfDefine to enable OIDC

* Add OIDC support to all dockerfiles

* Re add apache Require option

* Fixes and documentation

* A few more fixes

* A bit more doc

* Change type of environment variable

* Update readme

* Correct apache config for OIDC support.

* Fix README formatting

* Update oidc control path

* Fix oidc endpoint being cached

* A bit more review

* Simplify ExpiresActive

* Add session refresh and improve caching

* Allow more different setups

* A bit more documentation

* A bit more readme

---------

Co-authored-by: Aaron Schif <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>
Co-authored-by: maTh <[email protected]>

* Fix OpenID Connect crash on ARM (#5463)

Only enable the Apache auth_openidc module when actually used
Fix #5460
Follow-up of #5351

* Readme minor typo

* Fix: conf.php (German i18n) (#5468)

* Improved: update page (#5420)

* prependTitle()

* do not need the "damn" in the alert

* update page layout improved

* release channel

* i18n labels

* add log messages while updating

* Delete updatee.php

* Update updateController.php

* Update updateController.php

* Update updateController.php

* Update updateController.php

* add getCurrentGitBranch()

* Update updateController.php

* state2 buttons

* i18n

* loading

* Update feedback.php

* Update feedback.php

* Update feedback.php

* Update extra.js

* Apply suggestions from code review

Co-authored-by: Luc SANCHEZ <[email protected]>

* Update updateController.php

* Update terminology

* update button is now armed

---------

Co-authored-by: Luc SANCHEZ <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>

* Allow deep link to extension configuration (#5449)

* Allow deep link to extension configuration
Full screen

* Support slider

* Add aside_configure
Fix #5449 (comment)

* category title improved

* Feed title: better HTML structure + have a correct semantic <a>

* feed title: CSS

* feed title special cases

* improved feed mouseover titles

* cog icon half transparent. Shining while hovering

* i18n labels

* improve hover of more menu

* Update gen.php

* fix

* i18n: fr

---------

Signed-off-by: Christian König <[email protected]>
Co-authored-by: Luc SANCHEZ <[email protected]>
Co-authored-by: Luc <[email protected]>
Co-authored-by: Alexandre Alapetite <[email protected]>
Co-authored-by: Alexis Degrugillier <[email protected]>
Co-authored-by: vrachnis <[email protected]>
Co-authored-by: LleanaRuv <[email protected]>
Co-authored-by: acbgbca <[email protected]>
Co-authored-by: Alwaysin <[email protected]>
Co-authored-by: yubiuser <[email protected]>
Co-authored-by: Aaron Schif <[email protected]>
Co-authored-by: Aaron Schif <[email protected]>
Co-authored-by: math-gh <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@math-GH math-GH math-GH approved these changes

@ColonelMoutarde ColonelMoutarde ColonelMoutarde approved these changes

@marienfressinaud marienfressinaud Awaiting requested review from marienfressinaud

@aledeg aledeg Awaiting requested review from aledeg

@Frenzie Frenzie Awaiting requested review from Frenzie

Assignees
No one assigned
Labels
Extension 🔌 UI 🎨 User Interfaces
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Alkarex @math-GH @ColonelMoutarde